Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

expose additional fields on Analytics #111

Merged
merged 2 commits into from
Jun 23, 2017
Merged

expose additional fields on Analytics #111

merged 2 commits into from
Jun 23, 2017

Conversation

devoncarew
Copy link
Contributor

  • expose the Analytics.applicationName and Analytics.applicationVersion properties
  • make it easier for clients to extend the AnalyticsIO class
  • rev to 3.2.0

@kevmoo, @pq

@googlebot googlebot added the cla: yes Google CLA signed label Jun 23, 2017
pq
pq approved these changes Jun 23, 2017
View reviewed changes
Copy link
Contributor

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.analysis_options Outdated
@@ -1,2 +1,7 @@
analyzer:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename to analysis_options.yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@devoncarew devoncarew merged commit 6e51b7b into master Jun 23, 2017
@kevmoo kevmoo deleted the usage_3_2_0 branch September 21, 2017 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pq pq pq approved these changes

Assignees
No one assigned
Labels
cla: yes Google CLA signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devoncarew @pq @googlebot