[ML] MML calculator enhancements for multi-metric job wizard (elastic…

…#54573) * [ML] fix fieldNames provided to calculateModelMemoryLimit * [ML] calculateModelMemoryLimit when the influencers are changed
darnautov · Jan 14, 2020 · eaf1470 · eaf1470
1 parent 388303b
commit eaf1470
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...plugins/ml/public/application/jobs/new_job/common/job_creator/multi_metric_job_creator.ts b/...plugins/ml/public/application/jobs/new_job/common/job_creator/multi_metric_job_creator.ts
@@ -92,12 +92,11 @@ export class MultiMetricJobCreator extends JobCreator {
       // not split field, use the default
       this.modelMemoryLimit = DEFAULT_MODEL_MEMORY_LIMIT;
     } else {
-      const fieldNames = this._detectors.map(d => d.field_name).filter(fn => fn !== undefined);
       const { modelMemoryLimit } = await ml.calculateModelMemoryLimit({
         indexPattern: this._indexPatternTitle,
         splitFieldName: this._splitField.name,
         query: this._datafeed_config.query,
-        fieldNames,
+        fieldNames: this.fields.map(f => f.id),
         influencerNames: this._influencers,
         timeFieldName: this._job_config.data_description.time_field,
         earliestMs: this._start,

diff --git a/...ion/jobs/new_job/pages/components/pick_fields_step/components/influencers/influencers.tsx b/...ion/jobs/new_job/pages/components/pick_fields_step/components/influencers/influencers.tsx
@@ -25,6 +25,9 @@ export const Influencers: FC = () => {
   useEffect(() => {
     jobCreator.removeAllInfluencers();
     influencers.forEach(i => jobCreator.addInfluencer(i));
+    if (jobCreator instanceof MultiMetricJobCreator) {
+      jobCreator.calculateModelMemoryLimit();
+    }
     jobCreatorUpdate();
   }, [influencers.join()]);