Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dapr-bot support to assign issues #951

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Conversation

yash-nisar
Copy link
Contributor

@yash-nisar yash-nisar commented Sep 16, 2022

Closes #933

Signed-off-by: Yash Nisar yashnisar@microsoft.com

Description

Add dapr-bot support to assign issues
Tested it with my own personal access token here: yash-nisar#1

Issue reference

#933

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #933

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@yash-nisar yash-nisar requested review from a team as code owners September 16, 2022 01:35
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #951 (3cd02ff) into master (990139e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
+ Coverage   69.47%   69.49%   +0.01%     
==========================================
  Files         155      155              
  Lines        5130     5130              
  Branches      554      554              
==========================================
+ Hits         3564     3565       +1     
+ Misses       1435     1434       -1     
  Partials      131      131              
Flag Coverage Δ
net5 69.45% <ø> (+0.01%) ⬆️
net6 69.39% <ø> (ø)
netcoreapp3.1 69.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Dapr.Client/DaprClientGrpc.cs 86.72% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amulyavarote
Copy link
Contributor

Changes look good to me!

Closes dapr#933

Signed-off-by: Yash Nisar <yashnisar@microsoft.com>
@halspang halspang merged commit 37ed498 into dapr:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate dapr-bot support to assign issues
3 participants