[Docs refresh] Actors section refresh #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 155 155
Lines 5134 5134
Branches 554 554
=======================================
Hits 3569 3569
Misses 1434 1434
Partials 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
halspang
approved these changes
Sep 13, 2022
|
|
||
| The guidance in this document will focus on `IActorProxyFactory`. `ActorProxy`'s static method functionality is identical except for the ability to manage configuration centrally. | ||
| {{% alert title="Tip" color="primary" %}} | ||
| For a non-dependency-injected application, you can use the static methods on `ActorProxy`. Since the `ActorProxy` methods are error prone, try to avoid using them when configuring custom settings. |
There was a problem hiding this comment.
Nit: It feels odd to refer to our own code as "error prone". I wonder what the background of this comment is and if we still need to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hannah Hunter hannahhunter@microsoft.com
Description
Grammar and readability edits to the actors section.
Issue reference
#880
@nyemade-uversky @greenie-msft @msfussell