Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for getting the samples to work #570

Merged
merged 2 commits into from
Jan 30, 2021
Merged

fixes for getting the samples to work #570

merged 2 commits into from
Jan 30, 2021

Conversation

vinayada1
Copy link
Contributor

Description

  1. grpc sample needs a small fix.
  2. runtime behavior defaults the data content type to text. Needs to be explicitly set by the sdk

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #570 (4d55e38) into release-1.0.0 (aa41915) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-1.0.0     #570   +/-   ##
==============================================
  Coverage          65.84%   65.85%           
==============================================
  Files                120      120           
  Lines               3956     3957    +1     
  Branches             436      436           
==============================================
+ Hits                2605     2606    +1     
  Misses              1231     1231           
  Partials             120      120           
Impacted Files Coverage Δ
src/Dapr.Client/DaprClientGrpc.cs 87.68% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa41915...4d55e38. Read the comment docs.

@vinayada1 vinayada1 merged commit 7f9d23c into release-1.0.0 Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants