Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use daprWorkflowClient instead of daprClient in workflow sample #1212

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Dec 13, 2023

Description

Please refer to issue: #1205

@MregXN MregXN requested review from a team as code owners December 13, 2023 15:55
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7228406) 66.58% compared to head (a814847) 66.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1212   +/-   ##
=======================================
  Coverage   66.58%   66.58%           
=======================================
  Files         171      171           
  Lines        5752     5752           
  Branches      628      628           
=======================================
  Hits         3830     3830           
  Misses       1772     1772           
  Partials      150      150           
Flag Coverage Δ
net6 66.57% <ø> (ø)
net7 66.57% <ø> (ø)
net8 66.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MregXN <mregxn@gmail.com>
@MregXN MregXN force-pushed the remove-daprClient-for-workflow branch from 0eb828b to 6205170 Compare December 14, 2023 01:26
Copy link
Contributor

@cgillum cgillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@halspang halspang merged commit 7616bfa into dapr:master Jan 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants