Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Obsolete attribute from config API classes #1098

Merged
merged 2 commits into from
May 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ namespace ConfigurationApi.Controllers
{
[ApiController]
[Route("configuration")]
[Obsolete]
public class ConfigurationController : ControllerBase
{
private ILogger<ConfigurationController> logger;
Expand Down
3 changes: 1 addition & 2 deletions examples/Client/ConfigurationApi/Program.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using Microsoft.AspNetCore.Hosting;
using Microsoft.Extensions.Hosting;
using Dapr.Client;
Expand All @@ -10,7 +10,6 @@ namespace ConfigurationApi
{
public class Program
{
[Obsolete]
public static void Main(string[] args)
{
Console.WriteLine("Starting application.");
Expand Down
3 changes: 0 additions & 3 deletions src/Dapr.Client/DaprClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,6 @@ public abstract Task<Dictionary<string, Dictionary<string, string>>> GetBulkSecr
/// <param name="metadata">Optional metadata that will be sent to the configuration store being queried.</param>
/// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param>
/// <returns>A <see cref="Task"/> containing a <see cref="GetConfigurationResponse"/></returns>
[Obsolete("This API is currently not stable as it is in the Alpha stage. This attribute will be removed once it is stable.")]
public abstract Task<GetConfigurationResponse> GetConfiguration(
string storeName,
IReadOnlyList<string> keys,
Expand All @@ -922,7 +921,6 @@ public abstract Task<GetConfigurationResponse> GetConfiguration(
/// <param name="metadata">Optional metadata that will be sent to the configuration store being queried.</param>
/// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param>
/// <returns>A <see cref="SubscribeConfigurationResponse"/> which contains a reference to the stream.</returns>
[Obsolete("This API is currently not stable as it is in the Alpha stage. This attribute will be removed once it is stable.")]
public abstract Task<SubscribeConfigurationResponse> SubscribeConfiguration(
string storeName,
IReadOnlyList<string> keys,
Expand All @@ -936,7 +934,6 @@ public abstract Task<SubscribeConfigurationResponse> SubscribeConfiguration(
/// <param name="id">The Id of the subscription that should no longer be watched.</param>
/// <param name="cancellationToken">A <see cref="CancellationToken" /> that can be used to cancel the operation.</param>
/// <returns></returns>
[Obsolete("This API is currently not stable as it is in the Alpha stage. This attribute will be removed once it is stable.")]
public abstract Task<UnsubscribeConfigurationResponse> UnsubscribeConfiguration(
string storeName,
string id,
Expand Down
3 changes: 0 additions & 3 deletions src/Dapr.Client/DaprClientGrpc.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1286,7 +1286,6 @@ public async override Task<Dictionary<string, Dictionary<string, string>>> GetBu

#region Configuration API
/// <inheritdoc/>
[Obsolete]
public async override Task<GetConfigurationResponse> GetConfiguration(
string storeName,
IReadOnlyList<string> keys,
Expand Down Expand Up @@ -1330,7 +1329,6 @@ public async override Task<GetConfigurationResponse> GetConfiguration(
}

/// <inheritdoc/>
[Obsolete]
public override Task<SubscribeConfigurationResponse> SubscribeConfiguration(
string storeName,
IReadOnlyList<string> keys,
Expand Down Expand Up @@ -1361,7 +1359,6 @@ public override Task<SubscribeConfigurationResponse> SubscribeConfiguration(
return Task.FromResult(new SubscribeConfigurationResponse(new DaprSubscribeConfigurationSource(client.SubscribeConfiguration(request, options))));
}

[Obsolete]
public override async Task<UnsubscribeConfigurationResponse> UnsubscribeConfiguration(
string storeName,
string id,
Expand Down
1 change: 0 additions & 1 deletion src/Dapr.Client/SubscribeConfigurationResponse.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace Dapr.Client
/// <summary>
/// Response for a Subscribe Configuration request.
/// </summary>
[Obsolete("This response utilizes an alpha API which is subject to change. This attribute will be removed when the API is no longer Alpha.")]
public class SubscribeConfigurationResponse
{
private ConfigurationSource source;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ namespace Dapr.Extensions.Configuration
/// <summary>
/// Extension used to call the Dapr Configuration API and store the values in a <see cref="IConfiguration"/>.
/// </summary>
[Obsolete]
public static class DaprConfigurationStoreExtension
{
/// <summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ namespace Dapr.Extensions.Configuration
/// A configuration provider that utilizes the Dapr Configuration API. It can either be a single, constant
/// call or a streaming call.
/// </summary>
[Obsolete]
internal class DaprConfigurationStoreProvider : ConfigurationProvider, IDisposable
{
private string store;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ namespace Dapr.Extensions.Configuration
/// <summary>
/// Configuration source that provides a <see cref="DaprConfigurationStoreProvider"/>.
/// </summary>
[Obsolete]
public class DaprConfigurationStoreSource : IConfigurationSource
{
/// <summary>
Expand Down
1 change: 0 additions & 1 deletion test/Dapr.Client.Test/ConfigurationApiTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

namespace Dapr.Client.Test
{
[System.Obsolete]
public class ConfigurationApiTest
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion test/Dapr.Client.Test/ConfigurationSourceTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

namespace Dapr.Client.Test
{
[Obsolete]
public class ConfigurationSourceTest
{
private readonly string StoreName = "testStore";
Expand Down