fix: Use ignored variable in WorkflowServiceCollectionExtensions.AddDaprWorkflow #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
=======================================
Coverage 68.95% 68.95%
=======================================
Files 169 169
Lines 5534 5534
Branches 588 588
=======================================
Hits 3816 3816
Misses 1578 1578
Partials 140 140
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@tomkerkhove - Looks like there is a merge conflict, can you take a look at that? |
…aprWorkflow Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
@halspang We are good to go! |
halspang
approved these changes
Apr 17, 2023
onionhammer
pushed a commit
to onionhammer/dotnet-sdk
that referenced
this pull request
May 30, 2023
…aprWorkflow (dapr#1056) Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com> Signed-off-by: Erik O'Leary <erik.m.oleary@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ignored variable in WorkflowServiceCollectionExtensions.AddDaprWorkflow
Description
Use ignored variable in
WorkflowServiceCollectionExtensions.AddDaprWorkflowto remove duplication. (biggest nit ever)Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1055
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: