Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose HttpClient on ActorProxy #728

Closed
clintsinger opened this issue Jul 29, 2021 · 2 comments · Fixed by #748
Closed

Expose HttpClient on ActorProxy #728

clintsinger opened this issue Jul 29, 2021 · 2 comments · Fixed by #748
Assignees
@halspang
Milestone
v1.5

Comments

@clintsinger
Copy link

clintsinger commented Jul 29, 2021 •
edited
Loading

The ActorProxy doesn't allow access to the HttpClient. This is useful so that one would be able to add additional configuration such as being able to define the HttpClient.Timeout.

As an example use case, being able to set the Timeout to InfiniteTimespan when doing service debugging would help in scenarios when stepping through the code takes longer than the default timeout.
@halspang
Copy link
Contributor

/assign

@rynowak
Copy link
Contributor

rynowak commented Aug 26, 2021

@clintsinger - thanks for opening this. This seems like a good thing for us to make possible. @halspang - let's work on the design of this.

@rynowak rynowak added this to the v1.5 milestone Aug 31, 2021
@halspang halspang mentioned this issue Sep 2, 2021
Merged
3 tasks
halspang added a commit to halspang/dotnet-sdk that referenced this issue Sep 2, 2021
@halspang
Add an option to set Timeout for ActorProxy
4d85e74 
Actors, by there nature, may have to wait for a long period before
being allowed to execute. This could lead to long request times. The
default timeout for the HttpClient being used is fairly low. This
commit allows for the timeout to be set when constructing the
proxy.

dapr#728
rynowak pushed a commit that referenced this issue Sep 8, 2021
@halspang
Add an option to set Timeout for ActorProxy (#748)
cee49bf 
* Add an option to set Timeout for ActorProxy

Actors, by there nature, may have to wait for a long period before
being allowed to execute. This could lead to long request times. The
default timeout for the HttpClient being used is fairly low. This
commit allows for the timeout to be set when constructing the
proxy.

#728

* Removed extra constructor and e2e tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@halspang halspang

Labels
None yet
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

Add an option to set Timeout for ActorProxy halspang/dotnet-sdk
3 participants
@rynowak @clintsinger @halspang