Start of Python QS doc #3495
Merged
Start of Python QS doc #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
RyanLettieri
reviewed
Jun 6, 2023
RyanLettieri
reviewed
Jun 6, 2023
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
RyanLettieri
reviewed
Jun 6, 2023
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
hhunter-ms
requested changes
Jun 6, 2023
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
…start.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
…start.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
…start.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
…start.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
hhunter-ms
reviewed
Jun 6, 2023
daprdocs/content/en/getting-started/quickstarts/workflow-quickstart.md
Outdated
Show resolved
Hide resolved
…start.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: greenie-msft <56556602+greenie-msft@users.noreply.github.com>
Signed-off-by: Nick Greenfield <nigreenf@microsoft.com>
DeepanshuA
reviewed
Jun 7, 2023
| workflowRuntime.register_activity(update_inventory_activity) | ||
| workflowRuntime.start() | ||
|
|
||
| print("==========Begin the purchase of item:==========", flush=True) |
There was a problem hiding this comment.
It seems we have missed few lines here, like daprClient instantiation etc.
| - The workflow and the workflow activities it invokes are registered | ||
|
|
||
| ```python | ||
| class WorkflowConsoleApp: |
There was a problem hiding this comment.
In Step 2, we asked to git clone quickstarts package.
Do we need to provide app.py and workflow.py here?
There was a problem hiding this comment.
Sorry, can you clarify what you're suggesting we change?Sorry, can you clarify what you're suggesting we change?
hhunter-ms
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Adds python section to WF quickstart
Issue reference
#3377