-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rocketmq consumer config item description #3354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Signed-off-by: Naah <nayan3480232@163.com>
naah69
force-pushed
the
rocketmq-consumer
branch
from
April 26, 2023 04:17
b656248
to
b590d2f
Compare
hhunter-ms
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick review - thanks!
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rocketmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rocketmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rocketmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rocketmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rocketmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rocketmq.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-pubsub/setup-rocketmq.md
Outdated
Show resolved
Hide resolved
Stale PR, paging all reviewers |
done |
…ubsub/setup-rocketmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com> Signed-off-by: Naah <nayan3480232@163.com>
hhunter-ms
approved these changes
May 9, 2023
@naah69 could you pull in the build fixes from v1.11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, please fill out the following to help reviewers understand this pull request:
Description
add rocketmq consumer config item description.
Issue reference
dapr/components-contrib#2756