Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rocketmq consumer config item description #3354

Merged
merged 12 commits into from
May 9, 2023

Conversation

naah69
Copy link
Contributor

@naah69 naah69 commented Apr 26, 2023

In addition, please fill out the following to help reviewers understand this pull request:

Description

add rocketmq consumer config item description.

Issue reference

dapr/components-contrib#2756

Signed-off-by: Naah <nayan3480232@163.com>
Signed-off-by: Naah <nayan3480232@163.com>
Copy link
Collaborator

@hhunter-ms hhunter-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick review - thanks!

@github-actions
Copy link

github-actions bot commented May 4, 2023

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label May 4, 2023
@naah69
Copy link
Contributor Author

naah69 commented May 4, 2023

done

naah69 and others added 7 commits May 4, 2023 11:53
…ubsub/setup-rocketmq.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Naah <nayan3480232@163.com>
…ubsub/setup-rocketmq.md

Co-authored-by: Hannah Hunter <94493363+hhunter-ms@users.noreply.github.com>
Signed-off-by: Naah <nayan3480232@163.com>
@github-actions github-actions bot removed the stale label May 5, 2023
@hhunter-ms
Copy link
Collaborator

@naah69 could you pull in the build fixes from v1.11?

@hhunter-ms hhunter-ms merged commit 6b91df7 into dapr:v1.11 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants