Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workflow] Add purge/pause/resume/raise event to docs #3332

Merged
merged 40 commits into from
May 17, 2023
Merged

[Workflow] Add purge/pause/resume/raise event to docs #3332

merged 40 commits into from
May 17, 2023

Conversation

hhunter-ms
Copy link
Collaborator

@hhunter-ms hhunter-ms commented Apr 11, 2023 •
edited
Loading

Description

Add purge/pause/resume API methods to documentation:

  • Workflow API doc
  • How to manage workflows doc

Need:
Response body examples for Workflow API doc

Issue reference

PR will close: #3316 #3350 #3349

@hhunter-ms
add new methods to api doc
de3bdf6 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
add methods to how to
440b032 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms requested a review from a team as a code owner April 11, 2023 17:05
@hhunter-ms hhunter-ms requested a review from a team as a code owner April 11, 2023 17:05
@hhunter-ms hhunter-ms self-assigned this Apr 11, 2023
@hhunter-ms
update after v1.10 upmerge
9717f6d 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
updates per ryan
5a814fc 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@github-actions
Copy link

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 18, 2023
@github-actions github-actions bot closed this Apr 26, 2023
@hhunter-ms hhunter-ms reopened this Apr 28, 2023
@hhunter-ms hhunter-ms removed the stale label May 1, 2023
@hhunter-ms hhunter-ms added this to the 1.11 milestone May 1, 2023
@hhunter-ms
add raise event request
0480629 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms hhunter-ms changed the title [WIP][Workflow] Add purge/pause/resume to docs [WIP][Workflow] Add purge/pause/resume/raise event to docs May 1, 2023
@hhunter-ms hhunter-ms changed the title [WIP][Workflow] Add purge/pause/resume/raise event to docs [Workflow] Add purge/pause/resume/raise event to docs May 1, 2023
@hhunter-ms
add raise event api to the howto
ba52814 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
updates per Ryan;
32313dd 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
Merge branch 'v1.11' of https://github.com/dapr/docs into issue_3316
d81290a
@hhunter-ms
whitespace/updates
b8891b5 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
add more description to raise event
9116c21 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
clarify raise event and add to the dotnet sdk example
9cd800e 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
edit confusing text for raise event http
956f94e 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@cgillum
Copy link
Contributor

cgillum commented May 11, 2023

@hhunter-ms it should be PauseWorkflowAsync:

// Pause
await daprClient.PauseWorkflowAsync(orderId, workflowComponent);

@msfussell @cgillum
Update daprdocs/content/en/reference/api/workflow_api.md
969d403 
Co-authored-by: Chris Gillum <cgillum@gmail.com>
Signed-off-by: Mark Fussell <markfussell@gmail.com>
msfussell
msfussell reviewed May 15, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments. Still do not understand the Raise an event usage.

msfussell
msfussell reviewed May 15, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments. Still do not understand the Raise an event usage.

msfussell
msfussell reviewed May 15, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments. Still do not understand the Raise an event usage.

@hhunter-ms
updates per mark and chris
4b1efe7 
Signed-off-by: Hannah Hunter <hannahhunter@microsoft.com>
@hhunter-ms
Merge branch 'issue_3316' of https://github.com/hhunter-ms/docs into …
d45d120 
…issue_3316
@hhunter-ms
Copy link
Collaborator Author

@msfussell @cgillum @RyanLettieri thanks for the reviews! can you glance over it again to make sure I've addressed all your suggestions?

@RyanLettieri
Copy link
Contributor

LGTM

msfussell
msfussell approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@msfussell msfussell merged commit 2840ed7 into dapr:v1.11 May 17, 2023
@msfussell msfussell deleted the issue_3316 branch May 17, 2023 23:16
@hhunter-ms hhunter-ms mentioned this pull request Jun 7, 2023
Closed
7 tasks
This was referenced Feb 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum cgillum left review comments

@RyanLettieri RyanLettieri RyanLettieri left review comments

@msfussell msfussell msfussell approved these changes

Assignees

@RyanLettieri RyanLettieri

@hhunter-ms hhunter-ms

Labels
None yet
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@hhunter-ms @RyanLettieri @cgillum @msfussell