-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop duplicate aws auth field in postgresql #3525
fix: drop duplicate aws auth field in postgresql #3525
Conversation
1b089eb
to
6206aea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes lgtm, we definitely don't want duplicate fields. thx @Eileen-Yu.
cc @berndverst & @ItalyPaleAle & @yaron2 for confirmation & further approval
7a432d2
to
fe6fad8
Compare
6247eeb
to
75ec5d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit in comment.
.build-tools/pkg/metadataschema/builtin-authentication-profiles.go
Outdated
Show resolved
Hide resolved
75ec5d5
to
9627bca
Compare
Signed-off-by: Eileen Yu <eileenylj@gmail.com>
9627bca
to
27af5a3
Compare
golang ci lint seems failed for the code on main branch, will this block the merge? (sry I closed it accidentally 🤦♀️) |
bump for review/merge pls. Linter failures are unrelated to these changes, and occurring afterrrr a merge capturing changes from main. Not sure how they got into main without being corrected first... cc @ItalyPaleAle |
Signed-off-by: Eileen Yu <eileenylj@gmail.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Description
If choose postgresql
AWS: Access Key ID and Secret Access Key
as the Authentication Profile, there are multiple fields forAWS AccessKey, AWS Region, and AWS Secret Key" .
The reason is bc for PostgreSQL itself has
awsIAM
as the metadata, which already include accessKey, secretKey and awsRegion. But during the building it will append built-in auth profile again, which bring these duplicated fields. This PR tweak the logic of the building process, which filters out those fields for the postgres component.Before the change:
After the change:
This aligns with aws auth of other components.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: