Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kafka metadata opt-in setting to escapeHeaders #3524

Merged

Conversation

antontroshin
Copy link

Description

In continuation of the issue #3503, make the escaping headers Opt-in via the component setting

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #3503

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Signed-off-by: Anton Troshin <anton@diagrid.io>
@antontroshin antontroshin requested review from a team as code owners August 30, 2024 20:44
@antontroshin antontroshin mentioned this pull request Aug 30, 2024
3 tasks
@yaron2
Copy link
Member

yaron2 commented Aug 30, 2024

Please add the new metadata field to the metadata.yaml file

…d pubsub

Signed-off-by: Anton Troshin <anton@diagrid.io>
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-1.14@753d09e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
common/component/kafka/consumer.go 84.61% 2 Missing ⚠️
common/component/kafka/kafka.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14    #3524   +/-   ##
===============================================
  Coverage                ?   30.22%           
===============================================
  Files                   ?      304           
  Lines                   ?    37860           
  Branches                ?        0           
===============================================
  Hits                    ?    11442           
  Misses                  ?    25447           
  Partials                ?      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yaron2 yaron2 merged commit 27dfbaa into dapr:release-1.14 Aug 30, 2024
94 checks passed
@antontroshin antontroshin deleted the second-take-opt-in-kafka-escape-headers branch August 31, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants