Removes the dummy check for AWS Parameter Store access validation #3520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Kolevska <elena@kolevska.com>
yaron2
approved these changes
Aug 30, 2024
elena-kolevska
added a commit
to elena-kolevska/components-contrib
that referenced
this pull request
Sep 12, 2024
…pr#3520) Signed-off-by: Elena Kolevska <elena@kolevska.com> Co-authored-by: Yaron Schneider <schneider.yaron@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the writing to a dummy key to check for access, because that might be disallowed for some policies.
The change was introduced in 1.13 (#3301).
This needs to be patched into 1.13 and 1.14.
Issue reference
This issue was related to AWS Secrets manager, but the same applies for parameter store too.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: