Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binding AWS Kinesis - reuse client credentials #3509

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

soisyourface
Copy link
Contributor

Description

Should remove the need to define the AWS secret(key, id, session) information in the binding definition and instead use the existing AWS mechanisms of using metadata server, env, config, and other methods.

TODO: update documentation and code to be more obvious on what is going on. Also, will add a few lines about how this will create a DynamoDB table and how it is named.

Issue reference

Implements issue #3508

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@soisyourface soisyourface requested review from a team as code owners August 28, 2024 00:06
@soisyourface soisyourface changed the title reuse existing aws client credentials; Binding AWS Kinesis - reuse client credentials Aug 28, 2024
Signed-off-by: arr <ryan.despain@dave.com>
@yaron2 yaron2 merged commit 4c53816 into dapr:main Sep 9, 2024
87 of 89 checks passed
@marcduiker
Copy link
Contributor

@holopin-bot @soisyourface Thank you for your contribution!

Copy link

holopin-bot bot commented Oct 4, 2024

Congratulations @soisyourface, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm1ul22k7111290cjqm8vuk3y1

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants