Enhancement: Consider baseURI of referringElement (<base href="...">)

[eHtmlu]

#108

[dantleech]

Great thanks! Would be great if we could also add a test for this scenario in this test case:

fink/tests/EndToEnd/Command/CrawlCommandTest.php

Line 7 in cc30101

class CrawlCommandTest extends EndToEndTestCase

Maybe by setting up a new "test website" in tests/Example e.g. tests/Example/base-url

[dantleech]

Camel case would be more consistent $baseUri

[dantleech]

same

[dantleech]

maybe extract to a private method resolveBaseUri and remove the else?

[eHtmlu]

Thank you for all your hints! I tried to make all of these things. But I couldn't get the unit tests to run successfully on my machine. I think, however, my added test should work well. (don't know whether it's already automatically checked here).

[dantleech]

Nice work, thanks! The test works fine on Travis and on my local machine, strange that it doesn't on yours 🤔

[eHtmlu]

Nice work, thanks! The test works fine on Travis and on my local machine, strange that it doesn't on yours 🤔

Maybe I haven't installed it correctly.

If I do this:

git clone https://github.com/dantleech/fink.git .
composer install
./vendor/bin/phpunit

then I get many errors. It says the command "bin/fink" doesn't exist.

If I call "bin/fink" directly:

bin/fink http://example.com/

it works well 🤷‍♂️

Anyway, thanks for the merge! I'm happy I could help! 😊 ... was my first time making a pull request 😊