Fix vector env deletion (facebookresearch#185)

Explicitly call close for vector env to avoid issues with file writer prematurely close buffer when tensorboard enabled. See facebookresearch#184 for more info.
dannymcy · Aug 15, 2019 · 92d9e6d · 92d9e6d
1 parent e949db7
commit 92d9e6d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/habitat_baselines/rl/ppo/ppo_trainer.py b/habitat_baselines/rl/ppo/ppo_trainer.py
@@ -341,6 +341,8 @@ def train(self) -> None:
                     self.save_checkpoint(f"ckpt.{count_checkpoints}.pth")
                     count_checkpoints += 1
 
+            self.envs.close()
+
     def _eval_checkpoint(
         self,
         checkpoint_path: str,
@@ -554,3 +556,5 @@ def _eval_checkpoint(
             {"average success": episode_success_mean},
             checkpoint_index,
         )
+
+        self.envs.close()