Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull terminfo code out of windows build #2009

Closed
dankamongmen opened this issue Jul 31, 2021 · 3 comments
Closed

pull terminfo code out of windows build #2009

dankamongmen opened this issue Jul 31, 2021 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request mswindows microsoft windows
Milestone

Comments

@dankamongmen
Copy link
Owner

from what i can tell, terminfo isn't much of a thing on windows (@magiblot seconds this). i certainly haven't seen it work even through setupterm(). i think we ought just purge it from the windows build and assume windows terminal [shrug].

@dankamongmen dankamongmen added documentation Improvements or additions to documentation enhancement New feature or request mswindows microsoft windows labels Jul 31, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Jul 31, 2021
@dankamongmen dankamongmen self-assigned this Jul 31, 2021
@dankamongmen
Copy link
Owner Author

I've confirmed that it is indeed a failing call to setupterm() that is killing most of our Windows binaries out of the gate.

@dankamongmen
Copy link
Owner Author

and now we even print an error to that effect by default, huzzah.

@dankamongmen
Copy link
Owner Author

I've removed the calls to setupterm() and termname(). Indeed, on Windows we're no longer including ncurses.h. As expected we now hit "Required terminfo capability cup not defined", and exit with failure. That's no surprise at all. We now need to hardcode the various Windows Terminal escapes. We're almost there.

dankamongmen added a commit that referenced this issue Aug 3, 2021
dankamongmen added a commit that referenced this issue Aug 4, 2021
dankamongmen added a commit that referenced this issue Aug 4, 2021
dankamongmen added a commit that referenced this issue Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request mswindows microsoft windows
Projects
None yet
Development

No branches or pull requests

1 participant