Add the reject function at the expected errorIndex position in the args array #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want that the reject cb takes the position of an optional argument that has not been defined.
For example the Dialogs.alert method takes an optional 'buttonLabel' string. In case we do not set this value, and thus want to use the default value, the 'reject' callback get spliced into this position due the fact that the splice start index is bigger than the array length.
Dialogs.alert('mytitle', 'mymessage', 'Okay')
args will become:
["title", resolve, "message", "My button text", reject]
Dialogs.alert("title", "message")
args will become:
["title", resolve, "message", reject]
The latter will invoke the cordova-plugins-dialog alert method with the wrong arguments
--> reject is on the position of the buttonLabel
cordova-plugins-dialog alert method signature
alert: function(message, completeCallback, title, buttonLabel) {..}