fix(email-composer): Aligned function calls with Cordova plugin #3220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What happens with this kind of thing, does it ever get reviewed? |
danielsogl
added
the
target: patch
danielsogl
requested changes
Nov 19, 2019
Removed settings file because contained within .vscode that should not be included within the repository
|
OK I have deleted the settings.json file. Regards |
|
Hi, could you provide feedback on what has happened with this, it looks like I have failed to do something and you've closed it because of that? However it is very confusing on what exactly I am supposed to do? I assume because the .vscode settings file was committed in error that has caused the problem, I did delete that file change and thought that was adequate, what did I miss? |
|
You still committed the package-lock changes so I committed your changes by my self. |
|
ah OK sorry my apologies!
…On Tue, Nov 26, 2019 at 6:23 PM Daniel Sogl ***@***.***> wrote:
You still committed the package-lock changes so I committed your changes
by my self.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#3220>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMTGYGS5H4UZRYB4CBVPB6TQVVSTJANCNFSM4JH336RQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempt at contributing, I have read the guidelines and attempted to follow things as accurately as I can but any feedback to help me in the future is greatly received.
I have been having some major issues with the
cordova-plugin-email-composerplugin and after no useful feedback on Stackoverflow, Ionic Forum or Github I decided to delve in and see if I could remedy things myself.I have added the missing functions inline with the existing
cordova-plugin-email-composerdocumentation, specificallyhasAccount,hasClientandgetClients. I also modified the existingisAvailablefunction to maintain compatibility by combining thehasAccountandhasClientfunctions into a single function call for convenience.Apologies for the
.vscode/settings.jsonfile making an appearance in the changed files list.