-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(in-app-browser): update types to match cordova-plugin-inappbrowser 3.1.0 #3142
Conversation
Property comments are omitted if they are not marked with double asterisks. Added missing asterisks
Updated comments to match linter settings
After incorporating these changes into my app, I am still unable to get the beforeload to work properly. According to the Cordova documentation, they expect a callback parameter to be called, providing the URL if the beforeload should continue loading the URL. I don't see how the Observable in this implementation allows this, and in my experience with using it, it seems the URL never loads. Any advice? Thanks! |
It seems the |
i am getting the folllowing C:\Users\NANI>npm install -g cordova
C:\Users\NANI>cordova --version Error: Command failed: wmic os get Caption
code: 1, /*******************---------------------***********************- |
Closes #2744 as it includes the commit and fixes it's linting problems
Closes #2819 as it includes the new 3.1.0 options