Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(in-app-browser): update types to match cordova-plugin-inappbrowser 3.1.0 #3142

Merged
merged 4 commits into from
Aug 30, 2019

Conversation

jcesarmobile
Copy link
Contributor

Closes #2744 as it includes the commit and fixes it's linting problems
Closes #2819 as it includes the new 3.1.0 options

de-dan and others added 4 commits August 15, 2019 13:09
Property comments are omitted if they are not marked with double asterisks. Added missing asterisks
Updated comments to match linter settings
@danielsogl danielsogl self-assigned this Aug 15, 2019
@danielsogl danielsogl added the target: patch This PR is targeted for the next patch release label Aug 15, 2019
@danielsogl danielsogl merged commit 4d1e0e6 into danielsogl:master Aug 30, 2019
@jcesarmobile jcesarmobile deleted the iab-fix-types branch August 30, 2019 13:59
@jasonruesch
Copy link

After incorporating these changes into my app, I am still unable to get the beforeload to work properly. According to the Cordova documentation, they expect a callback parameter to be called, providing the URL if the beforeload should continue loading the URL. I don't see how the Observable in this implementation allows this, and in my experience with using it, it seems the URL never loads. Any advice? Thanks!

@timbru31
Copy link
Contributor

timbru31 commented Sep 2, 2019

It seems the customscheme event is missing: https://github.com/apache/cordova-plugin-inappbrowser/blob/c54d10052a42d5e68c76b53991c287a19cdce12c/www/inappbrowser.js#L41

@nani-samireddy
Copy link

i am getting the folllowing

C:\Users\NANI>npm install -g cordova
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated request@2.88.2: request has been deprecated, see request/request#3142
C:\Users\NANI\AppData\Roaming\npm\cordova -> C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\bin\cordova

  • cordova@9.0.0
    updated 1 package in 29.543s

C:\Users\NANI>cordova --version
C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\node_modules\execa\index.js:347
throw err;
^

Error: Command failed: wmic os get Caption
'wmic' is not recognized as an internal or external command,
operable program or batch file.

at makeError (C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\node_modules\execa\index.js:174:9)
at Function.module.exports.sync (C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\node_modules\execa\index.js:338:15)
at windowsRelease (C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\node_modules\windows-release\index.js:39:19)
at osName (C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\node_modules\os-name\index.js:39:18)
at new Insight (C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\node_modules\insight\lib\index.js:37:13)
at Object.<anonymous> (C:\Users\NANI\AppData\Roaming\npm\node_modules\cordova\src\telemetry.js:26:15)
at Module._compile (internal/modules/cjs/loader.js:1156:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1176:10)
at Module.load (internal/modules/cjs/loader.js:1000:32)
at Function.Module._load (internal/modules/cjs/loader.js:899:14) {

code: 1,
stdout: '',
stderr: "'wmic' is not recognized as an internal or external command,\r\n" +
'operable program or batch file.\r\n',
failed: true,
signal: null,
cmd: 'wmic os get Caption',
timedOut: false
}

/*******************---------------------***********************-
help me guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InAppBrowser.on(‘beforeload’) not working
6 participants