Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file): alternate file implementation #283

Merged
merged 12 commits into from
Aug 11, 2016
Merged

feat(file): alternate file implementation #283

merged 12 commits into from
Aug 11, 2016

Conversation

ihadeed
Copy link
Collaborator

@ihadeed ihadeed commented Jul 11, 2016

This is an alternative file implementation, written by @rapropos

closes #264
closes #254
closes #233
closes #159
closes #123

@ihadeed
Copy link
Collaborator Author

ihadeed commented Jul 11, 2016

It would be appreciated if someone can give this a quick test, here's an npm package build ready to use:
https://www.dropbox.com/s/x5589dwg93qdvap/ionic-native-1.3.2.tgz?dl=0

@ghenry22
Copy link
Contributor

I'll try and give it a test this week

@rapropos
Copy link
Contributor

Do I need to do something to address the conflict warning?

@ihadeed ihadeed modified the milestones: v1.3.10, v1.3.11 Jul 28, 2016
@ihadeed
Copy link
Collaborator Author

ihadeed commented Jul 28, 2016

@rapropos

I'll fix the conflict.

I was wondering, do all the functions in this implementation work a 100%? If so I will just merge it without testing it personally.

@rapropos
Copy link
Contributor

rapropos commented Aug 1, 2016

Sorry, I have not tested every single function, because I don't have client code that uses all of them.

@ihadeed ihadeed merged commit 6ed32ef into master Aug 11, 2016
@ihadeed ihadeed deleted the dev branch August 11, 2016 11:21
export * from './plugins/facebook';
>>>>>>> master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihadeed, looks like some git merge issues in this file.

Thanks,
Dan

Copy link
Collaborator Author

@ihadeed ihadeed Aug 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danbucholtz Already fixed!

@danbucholtz
Copy link

@ihadeed, you rock! 💯

@teledemic
Copy link

teledemic commented Aug 16, 2016

I can see the different directory constants (cacheDirectory etc) are in there which is great. But I can't figure out how to access them! Can you post an example of a simple "check if file exists" or similar?

Edit: never mind, I guess the directory constants never made it into master. Would still love to see an example as my old code no longer works with this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment