Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(media): add missing pauseRecord and resumeRecord methods #1122

Merged
merged 1 commit into from
Feb 28, 2017
Merged

fix(media): add missing pauseRecord and resumeRecord methods #1122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/plugins/media.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,21 @@ export class MediaPlugin {
})
stopRecord(): void { }

/**
* Pauses recording
*/
@CordovaInstance({
sync: true
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add platforms: ['iOS'] to both methods? just below sync: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm the docs seem to be out of date since Android is also supported, which i've verified on my device

https://github.com/apache/cordova-plugin-media/blob/88a69305eb7f2e7c03481f951a1d349f2a8b4ad0/src/android/AudioHandler.java#L123

pauseRecord(): void { }

/**
* Resumes recording
*/
@CordovaInstance({
sync: true
})
resumeRecord(): void { }

/**
* Stops playing an audio file.
Expand Down