Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default facebook logEvent parameters #1088

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Fix default facebook logEvent parameters #1088

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae2b425
Fix default facebook logEvent parameters
NoelDeMartin Feb 17, 2017
e7603fd
Implement correct parameters format in facebook logEvent method
NoelDeMartin Feb 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/facebook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,8 +235,8 @@ export class Facebook {
@Cordova()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This decorator should be:

@Cordova({
  successIndex: 3,
  errorIndex: 4
})

static logEvent(
name: string,
params?: Object,
valueToSum?: number
params: Object = null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding default values wont make a difference since the method will be overwritten by the decorator.

valueToSum: number = null
): Promise<any> { return; }

/**
Expand Down