adding lgtm code quality

daniel-sc · Feb 9, 2022 · 7e2da14 · 7e2da14
1 parent 88a2098
commit 7e2da14
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -2,6 +2,7 @@
 
 [![npm](https://img.shields.io/npm/v/bash-converter)](https://www.npmjs.com/package/bash-converter)
 [![Coverage Status](https://coveralls.io/repos/github/daniel-sc/bash-shell-to-bat-converter/badge.svg?branch=master)](https://coveralls.io/github/daniel-sc/bash-shell-to-bat-converter?branch=master)
+[![Language grade: JavaScript](https://img.shields.io/lgtm/grade/javascript/g/daniel-sc/bash-shell-to-bat-converter.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/daniel-sc/bash-shell-to-bat-converter/context:javascript)
 
 Converts bash scripts (`*.sh`) to windows batch files (`*.bat`). 
 This is _not_ supposed to be a fully complete/correct tool, but rather a starting point when converting scripts. 

diff --git a/src/convert-bash.ts b/src/convert-bash.ts
@@ -1,7 +1,7 @@
 // patch for irrelevant node dependency of bash-parser:
 if (typeof window === 'undefined') {
     // @ts-ignore
-    let window = {process: {env: {NODE_NEV: 'mock'}}};
+    let window = {process: {env: {NODE_NEV: 'mock'}}}; // lgtm [js/unused-local-variable]
     // @ts-ignore
 } else if (!window.process) {
     // @ts-ignore
@@ -71,7 +71,7 @@ class ConvertBash {
                             return this.cpHandler.handle(command);
 
                         default:
-                            return `${command.name.text}${suffix}`
+                            return `${command.name.text}${suffix}`;
                     }
                 }
                 return 'unknown command: ' + JSON.stringify(command);

diff --git a/src/cp-handler.ts b/src/cp-handler.ts
@@ -7,7 +7,7 @@ export class CpHandler implements CommandHandler {
     }
 
     handle(command: any): string {
-        const {singleDashParams, doubleDashParams, argList} = splitParams(command);
+        const {singleDashParams, argList} = splitParams(command);
         const winParams: string[] = [];
         singleDashParams.forEach(suffix => {
             if (suffix.text.indexOf('d') >= 0) {

diff --git a/src/rm-handler.ts b/src/rm-handler.ts
@@ -7,7 +7,7 @@ export class RmHandler implements CommandHandler {
     }
 
     handle(command: any): string {
-        const {singleDashParams, doubleDashParams, argList} = splitParams(command);
+        const {singleDashParams, argList} = splitParams(command);
         const winParams: string[] = [];
         singleDashParams.forEach(suffix => {
             if (suffix.text.indexOf('r') >= 0) {