Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting version to min version if not available #994

Merged
merged 1 commit into from
May 2, 2022
Merged

Conversation

TheChymera
Copy link
Contributor

@TheChymera TheChymera commented May 2, 2022

Closes: #990

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #994 (ceac616) into master (b73f44d) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   87.52%   87.48%   -0.05%     
==========================================
  Files          64       64              
  Lines        8106     8109       +3     
==========================================
- Hits         7095     7094       -1     
- Misses       1011     1015       +4     
Flag Coverage Δ
unittests 87.48% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/bids_validator_xs.py 92.28% <50.00%> (-0.63%) ⬇️
dandi/organize.py 81.85% <0.00%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b73f44d...ceac616. Read the comment docs.

@yarikoptic
Copy link
Member

Looks lgtm albeit not accompanied with a unit test, so mileage can vary. Let's proceed, I will add patch level label

@yarikoptic yarikoptic added the patch Increment the patch version when merged label May 2, 2022
@yarikoptic yarikoptic merged commit 1e3fbd4 into master May 2, 2022
@yarikoptic yarikoptic deleted the error branch May 2, 2022 14:43
@github-actions
Copy link

github-actions bot commented May 5, 2022

🚀 PR was released in 0.39.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BIDS patch Increment the patch version when merged released severity-minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should error out with some meaningful error
2 participants