Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better detection of empty directories when download-syncing Zarrs #961

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 15, 2022

No description provided.

@jwodder jwodder added the patch Increment the patch version when merged label Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #961 (f9dfd6d) into master (d3dc616) will increase coverage by 0.04%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
+ Coverage   87.27%   87.31%   +0.04%     
==========================================
  Files          65       65              
  Lines        8107     8118      +11     
==========================================
+ Hits         7075     7088      +13     
+ Misses       1032     1030       -2     
Flag Coverage Δ
unittests 87.31% <94.11%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/download.py 87.24% <75.00%> (+0.29%) ⬆️
dandi/tests/test_download.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3dc616...f9dfd6d. Read the comment docs.

@yarikoptic
Copy link
Member

not clear from the description on how it is better, but seems to come with a test to demonstrate its superiority, so must be right :) Thank you @jwodder

@yarikoptic yarikoptic merged commit 0b7cf59 into master Apr 15, 2022
@yarikoptic yarikoptic deleted the zarr-dl-all-dirs branch April 15, 2022 15:32
@github-actions
Copy link

🚀 PR was released in 0.39.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants