Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator fixes: fallback to our version, skip dotdirs on windows, etc #955

Merged
merged 13 commits into from
Apr 19, 2022

Conversation

TheChymera
Copy link
Contributor

@TheChymera TheChymera commented Apr 11, 2022

Miscellaneous but important improvements developed in parallel.
I will ping for review later, there are a few more.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #955 (1a6d835) into master (b08cae0) will increase coverage by 0.25%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   87.33%   87.58%   +0.25%     
==========================================
  Files          65       65              
  Lines        8099     8119      +20     
==========================================
+ Hits         7073     7111      +38     
+ Misses       1026     1008      -18     
Flag Coverage Δ
unittests 87.58% <85.71%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_bids_validator_xs.py 100.00% <ø> (ø)
dandi/bids_validator_xs.py 93.52% <85.71%> (+7.96%) ⬆️
dandi/files.py 78.66% <0.00%> (-1.13%) ⬇️
dandi/tests/test_files.py 100.00% <0.00%> (ø)
dandi/tests/test_download.py 100.00% <0.00%> (ø)
dandi/tests/fixtures.py 97.92% <0.00%> (+0.02%) ⬆️
dandi/download.py 87.24% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b08cae0...1a6d835. Read the comment docs.

@jwodder
Copy link
Member

jwodder commented Apr 13, 2022

@TheChymera Is this PR finished/ready for review? If not, please mark it as a draft until it is done.

@TheChymera
Copy link
Contributor Author

@jwodder should be good to go now. Sorry for the delay :(

@TheChymera TheChymera mentioned this pull request Apr 18, 2022
3 tasks
dandi/bids_validator_xs.py Outdated Show resolved Hide resolved
@yarikoptic yarikoptic added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 19, 2022
@yarikoptic yarikoptic changed the title Validator fixes Validator fixes: fallback to our version, skip dotdirs on windows, etc Apr 19, 2022
@yarikoptic
Copy link
Member

I adjusted title to be descriptive (will go into changelog), added labels including the one for release -- let's proceed. Thank you @TheChymera

@yarikoptic yarikoptic merged commit b890375 into master Apr 19, 2022
@yarikoptic yarikoptic deleted the validator_fixes branch April 19, 2022 12:45
@github-actions
Copy link

🚀 PR was released in 0.39.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants