Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify Dandiset ID when creating a Zarr #911

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Specify Dandiset ID when creating a Zarr #911

merged 1 commit into from
Feb 15, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 15, 2022

@jwodder jwodder added the patch Increment the patch version when merged label Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #911 (5b5b091) into master (79179bd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #911      +/-   ##
==========================================
+ Coverage   86.82%   86.86%   +0.04%     
==========================================
  Files          61       61              
  Lines        7424     7424              
==========================================
+ Hits         6446     6449       +3     
+ Misses        978      975       -3     
Flag Coverage Δ
unittests 86.86% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/files.py 79.82% <100.00%> (ø)
dandi/download.py 86.96% <0.00%> (-0.35%) ⬇️
dandi/dandiarchive.py 84.42% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79179bd...5b5b091. Read the comment docs.

@yarikoptic
Copy link
Member

yarikoptic commented Feb 15, 2022

@dchiquito since CI is all green, should I assume that it is just safe to provide dandiset_id even now without that dandi/dandi-archive#897 yet merged?

edit: if so -- might be worth a separate issue then, since even if it is a "convenience", IMHO in the long term the API should be more "explicit" and not just swallow arguments (without error) it doesn't recognize ATM.

@dchiquito
Copy link
Contributor

The API server will indeed swallow any unused arguments silently, so passing integration tests are expected.
I personally think that specifying undefined parameters is undefined behavior, and ignoring them is a perfectly valid way of handling them. If you think otherwise feel free to file a dandi-archive issue

@yarikoptic
Copy link
Member

If you think otherwise feel free to file a dandi-archive issue

done: dandi/dandi-archive#900 Meanwhile, let's proceed with this PR. I will not mark it for release for now -- let's see integration testing in dandi-archive to turn green!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants