Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark a test with missing skipif_no_network marker #886

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 25, 2022

No description provided.

@jwodder jwodder added the tests Add or improve existing tests label Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #886 (e5a6dd4) into master (1585b4d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #886      +/-   ##
==========================================
+ Coverage   86.66%   86.69%   +0.02%     
==========================================
  Files          61       61              
  Lines        7194     7195       +1     
==========================================
+ Hits         6235     6238       +3     
+ Misses        959      957       -2     
Flag Coverage Δ
unittests 86.69% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_metadata.py 100.00% <100.00%> (ø)
dandi/support/tests/test_iterators.py 100.00% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1585b4d...e5a6dd4. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you!

@yarikoptic yarikoptic merged commit f5e3fba into master Jan 26, 2022
@yarikoptic yarikoptic deleted the species-no-network branch January 26, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants