Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete functions (get_asset_metadata, find_dandi_files) obsoleted by PR #853 #885

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 25, 2022

  • get_asset_metadata() in metadata.py has been replaced by the get_metadata() methods of the LocalAsset class hierarchy in files.py
  • find_dandi_files() in util.py has been replaced by find_dandi_files() in files.py

@jwodder jwodder added the internal Changes only affect the internal API label Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #885 (ebcc30c) into master (1585b4d) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
+ Coverage   86.66%   86.83%   +0.16%     
==========================================
  Files          61       61              
  Lines        7194     7178      -16     
==========================================
- Hits         6235     6233       -2     
+ Misses        959      945      -14     
Flag Coverage Δ
unittests 86.83% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/metadata.py 83.28% <ø> (+2.68%) ⬆️
dandi/utils.py 81.26% <ø> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1585b4d...ebcc30c. Read the comment docs.

@yarikoptic
Copy link
Member

do we use any of those anywhere in our scripts? (e.g. in dandisets)

@jwodder
Copy link
Member Author

jwodder commented Jan 26, 2022

@yarikoptic Grepping the local clones I have of most of our repos turns up no uses.

@yarikoptic yarikoptic changed the title Delete functions obsoleted by PR #853 Delete functions (get_asset_metadata, find_dandi_files) obsoleted by PR #853 Jan 26, 2022
@yarikoptic
Copy link
Member

adjusted title (for auto'ed changelog), let's proceed.

@yarikoptic yarikoptic merged commit 1344e20 into master Jan 26, 2022
@yarikoptic yarikoptic deleted the rm-obsolete branch January 26, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants