Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bad versions list in .et #866

Merged
merged 1 commit into from
Jan 17, 2022
Merged

Update bad versions list in .et #866

merged 1 commit into from
Jan 17, 2022

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jan 17, 2022

See discussion in #863.

@jwodder jwodder added the internal Changes only affect the internal API label Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #866 (44dc3dc) into master (433380a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #866      +/-   ##
==========================================
- Coverage   86.55%   86.50%   -0.05%     
==========================================
  Files          58       58              
  Lines        6067     6067              
==========================================
- Hits         5251     5248       -3     
- Misses        816      819       +3     
Flag Coverage Δ
unittests 86.50% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiarchive.py 85.99% <0.00%> (-2.42%) ⬇️
dandi/download.py 82.44% <0.00%> (-0.54%) ⬇️
dandi/dandiapi.py 89.57% <0.00%> (-0.18%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 433380a...44dc3dc. Read the comment docs.

@yarikoptic
Copy link
Member

I guess let's do it and see if it would help us

@yarikoptic yarikoptic merged commit 07b0348 into master Jan 17, 2022
@yarikoptic yarikoptic deleted the update-et branch January 17, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants