Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dandi ls --help and dandi download --help output #827

Merged
merged 4 commits into from
Nov 5, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Nov 1, 2021

Closes #823.

@jwodder jwodder added the documentation Changes only affect the documentation label Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #827 (e4ff4c8) into master (d42938c) will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   85.48%   85.20%   -0.29%     
==========================================
  Files          61       61              
  Lines        6298     6298              
==========================================
- Hits         5384     5366      -18     
- Misses        914      932      +18     
Flag Coverage Δ
unittests 85.20% <100.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_download.py 92.30% <100.00%> (ø)
dandi/cli/cmd_ls.py 69.71% <100.00%> (ø)
dandi/dandiarchive.py 86.34% <100.00%> (-1.47%) ⬇️
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/dandiapi.py 89.00% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d42938c...e4ff4c8. Read the comment docs.

@yarikoptic
Copy link
Member

Looks and works great, thank you @jwodder !

@yarikoptic yarikoptic merged commit 365f08f into master Nov 5, 2021
@yarikoptic yarikoptic deleted the gh-823 branch November 5, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: known "patterns" to be displayed also for "download"
2 participants