Stop using setup_requires
#811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #811 +/- ##
=======================================
Coverage 84.64% 84.64%
=======================================
Files 61 61
Lines 6153 6153
=======================================
Hits 5208 5208
Misses 945 945
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
I don't remember if we kept it for compatibility... and we have not furnished *debian package(s) yet. I bet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of the release of setuptools v58.3.0 minutes ago, the
setup_requiresargument tosetup()is now officially deprecated. It can and should be replaced bybuild-system.requiresinpyproject.toml, which we've already done.(I seem to vaguely recall a mention that this option was being kept in dandi-cli for buildability on Debian or something like that? Is that still a concern?)