Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry more requests; wait longer for Dandiset validity #798

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 11, 2021

As requested here.

(Submitting as a separate PR because it really has nothing to do with what #797 is accomplishing.)

@jwodder jwodder added the patch Increment the patch version when merged label Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #798 (f5957fa) into master (2e7be6a) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
- Coverage   85.31%   85.14%   -0.17%     
==========================================
  Files          59       59              
  Lines        6066     6067       +1     
==========================================
- Hits         5175     5166       -9     
- Misses        891      901      +10     
Flag Coverage Δ
unittests 85.14% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/consts.py 100.00% <100.00%> (ø)
dandi/dandiapi.py 92.54% <100.00%> (-0.20%) ⬇️
dandi/dandiarchive.py 82.23% <100.00%> (ø)
dandi/download.py 82.24% <100.00%> (ø)
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e7be6a...f5957fa. Read the comment docs.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 11, 2021
@yarikoptic
Copy link
Member

thank you! Looks LGTM and since could help to mitigate false fails on CIs for downstream/integration testing done IIRC against releases, I have marked it for release. Let's proceed!

@yarikoptic yarikoptic merged commit 9390f0d into master Oct 11, 2021
@yarikoptic yarikoptic deleted the gh-797 branch October 11, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants