Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI tests dump Docker Compose logs on failure #793

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 6, 2021

So that @dchiquito can figure out why we keep getting intermittent "Digest is missing dandi-etag or sha256 keys." errors.

@jwodder jwodder added the tests Add or improve existing tests label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #793 (e4aaf27) into master (c9f00c7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #793   +/-   ##
=======================================
  Coverage   85.07%   85.07%           
=======================================
  Files          59       59           
  Lines        6055     6055           
=======================================
  Hits         5151     5151           
  Misses        904      904           
Flag Coverage Δ
unittests 85.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 96.37% <0.00%> (-0.73%) ⬇️
dandi/delete.py 91.66% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a196e4d...e4aaf27. Read the comment docs.

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Oct 6, 2021
@yarikoptic
Copy link
Member

ok, lets merge and release in the hope it would come handy ;)

@yarikoptic yarikoptic merged commit 4ac8f95 into master Oct 6, 2021
@yarikoptic yarikoptic deleted the docker-logs branch October 6, 2021 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants