Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docs to use "furo" theme #790

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Change docs to use "furo" theme #790

merged 1 commit into from
Oct 6, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Oct 6, 2021

I don't like Alabaster's lack of spacing between consecutive classes, so I thought I'd suggest switching to the latest hotness, furo.

@jwodder jwodder added the documentation Changes only affect the documentation label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #790 (78bda98) into master (8313173) will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   85.25%   84.91%   -0.34%     
==========================================
  Files          59       59              
  Lines        6041     6041              
==========================================
- Hits         5150     5130      -20     
- Misses        891      911      +20     
Flag Coverage Δ
unittests 84.91% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/conftest.py 38.46% <0.00%> (-61.54%) ⬇️
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/download.py 81.69% <0.00%> (-0.55%) ⬇️
dandi/dandiapi.py 92.46% <0.00%> (-0.20%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8313173...78bda98. Read the comment docs.

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@yarikoptic
Copy link
Member

ok, let's proceed with docs tune up PRs. Thank you @jwodder

@yarikoptic yarikoptic merged commit f1ee170 into master Oct 6, 2021
@yarikoptic yarikoptic deleted the furo branch October 6, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants