Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dandischema version #775

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Update dandischema version #775

merged 3 commits into from
Sep 28, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 27, 2021

No description provided.

@jwodder jwodder added the dependencies Update one or more dependencies version label Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #775 (46b0ad8) into master (7bba7ff) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #775      +/-   ##
==========================================
- Coverage   85.08%   84.90%   -0.18%     
==========================================
  Files          59       59              
  Lines        6040     6042       +2     
==========================================
- Hits         5139     5130       -9     
- Misses        901      912      +11     
Flag Coverage Δ
unittests 84.90% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/dandiapi.py 92.46% <0.00%> (-0.39%) ⬇️
dandi/tests/test_download.py 100.00% <0.00%> (ø)
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bba7ff...46b0ad8. Read the comment docs.

@jwodder
Copy link
Member Author

jwodder commented Sep 27, 2021

The tests are failing because the dandi-api code doesn't yet support the new schema version, and so attempts to publish Dandisets are failing.

@yarikoptic
Copy link
Member

ufff... these tight dependencies keep making it "too rigid"... clearly we don't want to merge/release until dandi-api main deployment updates to newer version. In the longer run I think we should start supporting multiple (two) "minor" versions of dandischema in dandi-cli, have matrix runs while testing against both, and then skip tests against "next" dandischema version whenever dandi-api is not support it. But I guess we should not bother with that just yet.

@yarikoptic
Copy link
Member

per your dandi/dandi-schema#88 (comment) -- and since we should not merge/release until main (non-staging) instance progresses forward to the next dandischema version, should we at least merge 024b93b and 45a4215 interim and keep this PR clearly only boosting dandischema version?

@jwodder
Copy link
Member Author

jwodder commented Sep 27, 2021

@yarikoptic Commits split off into PRs #776 and #777.

setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
@yarikoptic yarikoptic added the release Create a release when this pr is merged label Sep 28, 2021
@yarikoptic
Copy link
Member

@satra - merge to release ;-)

@satra satra merged commit 9011701 into master Sep 28, 2021
@satra satra deleted the update-dandischema branch September 28, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version release Create a release when this pr is merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants