-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dandischema version #775
Conversation
Codecov Report
@@ Coverage Diff @@
## master #775 +/- ##
==========================================
- Coverage 85.08% 84.90% -0.18%
==========================================
Files 59 59
Lines 6040 6042 +2
==========================================
- Hits 5139 5130 -9
- Misses 901 912 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
The tests are failing because the dandi-api code doesn't yet support the new schema version, and so attempts to publish Dandisets are failing. |
ufff... these tight dependencies keep making it "too rigid"... clearly we don't want to merge/release until dandi-api main deployment updates to newer version. In the longer run I think we should start supporting multiple (two) "minor" versions of dandischema in dandi-cli, have matrix runs while testing against both, and then skip tests against "next" dandischema version whenever dandi-api is not support it. But I guess we should not bother with that just yet. |
per your dandi/dandi-schema#88 (comment) -- and since we should not merge/release until main (non-staging) instance progresses forward to the next dandischema version, should we at least merge 024b93b and 45a4215 interim and keep this PR clearly only boosting dandischema version? |
024b93b
to
8af5d54
Compare
@yarikoptic Commits split off into PRs #776 and #777. |
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
@satra - merge to release ;-) |
No description provided.