Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Compose spin-up code for loss of --username option #768

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 13, 2021

See dandi/dandi-schema#82 for more information.

Until the next rebuild of the dandi-api image on the Docker Hub, this PR will make dandi-cli's tests fail, so don't merge until then. Once it's merged, the dandi-cli integration tests for dandischema (for the master version of dandi-cli, not the released version) will start passing again.

@jwodder jwodder added the tests Add or improve existing tests label Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #768 (af73933) into master (e78fbeb) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   85.13%   84.96%   -0.17%     
==========================================
  Files          59       59              
  Lines        6040     6040              
==========================================
- Hits         5142     5132      -10     
- Misses        898      908      +10     
Flag Coverage Δ
unittests 84.96% <100.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 97.16% <100.00%> (ø)
dandi/support/generatorify.py 0.00% <0.00%> (-16.10%) ⬇️
dandi/dandiapi.py 92.64% <0.00%> (-0.20%) ⬇️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78fbeb...af73933. Read the comment docs.

@yarikoptic
Copy link
Member

Until the next rebuild of the dandi-api image on the Docker Hub

so I just should trigger rebuild ? triggered on https://hub.docker.com/repository/docker/dandiarchive/dandiarchive-api/builds

@jwodder
Copy link
Member Author

jwodder commented Sep 13, 2021

@yarikoptic The tests pass now.

@yarikoptic
Copy link
Member

AWESOME! Let's cherish the moment with the merge. Thank you @jwodder !

@yarikoptic
Copy link
Member

IIRC we might be testing against released version, so I will also mark this for release

@yarikoptic yarikoptic added the release Create a release when this pr is merged label Sep 13, 2021
@yarikoptic yarikoptic merged commit a5dc75d into master Sep 13, 2021
@yarikoptic yarikoptic deleted the no-username branch September 13, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants