Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new published version of 000027 in tests #763

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Use new published version of 000027 in tests #763

merged 1 commit into from
Aug 31, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Aug 31, 2021

Closes #261.

@jwodder jwodder added the tests Add or improve existing tests label Aug 31, 2021
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #763 (cd2a269) into master (3341f98) will decrease coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #763      +/-   ##
==========================================
- Coverage   84.83%   84.13%   -0.70%     
==========================================
  Files          59       59              
  Lines        6027     6027              
==========================================
- Hits         5113     5071      -42     
- Misses        914      956      +42     
Flag Coverage Δ
unittests 84.13% <100.00%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/test_download.py 100.00% <100.00%> (ø)
dandi/cli/tests/test_download.py 63.63% <0.00%> (-36.37%) ⬇️
dandi/cli/cmd_download.py 69.23% <0.00%> (-28.85%) ⬇️
dandi/cli/base.py 92.10% <0.00%> (-5.27%) ⬇️
dandi/dandiset.py 82.89% <0.00%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3341f98...cd2a269. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you! Failing test is 400 from redirect, #762 yet to be merged

@yarikoptic yarikoptic merged commit 2832287 into master Aug 31, 2021
@yarikoptic yarikoptic deleted the gh-261 branch August 31, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to use api.dandiarchive.org instead of publish.dandiarchive.org
2 participants