Retry following redirects that return 404 #734
Conversation
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 84.12% 84.15% +0.03%
==========================================
Files 59 59
Lines 5699 5706 +7
==========================================
+ Hits 4794 4802 +8
+ Misses 905 904 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| return r.url | ||
| return url | ||
| i = 0 | ||
| while True: |
There was a problem hiding this comment.
why custom loop, I thought that we have try_multiple using tenacity for such purposes?
There was a problem hiding this comment.
try_multiple() doesn't support the 0.1, 1, 10 sequence of sleep times that you requested.
There was a problem hiding this comment.
it could be any reasonable sequence it supports, I do not care about precise timing, just spread it so it tries for up to 10ish seconds
There was a problem hiding this comment.
I feel that, in this case, the code is simpler without involving try_multiple().
There was a problem hiding this comment.
ok, I will resort to your judgement, lets proceed, thank you!
|
note: restarted tests since some were failing for some |
Closes #727.