RF: attempt nwb metadata extraction only on .nwb, if fails -- warning #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintaining prior behavior of re-raising the exception if allow_any_path is False. Otherwise -- and regardless if allow_any_path is True or not (thus would not re-raise for non .nwb files even if not allow_any_path) - provide default metadata record. For upload it should be fine AFAIK even with the change of behavior since we first use allow_any_path to select .nwb files. Closes #730
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
==========================================
- Coverage 84.12% 84.09% -0.03%
==========================================
Files 59 59
Lines 5699 5702 +3
==========================================
+ Hits 4794 4795 +1
- Misses 905 907 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jwodder
requested changes
Jul 22, 2021
dandi/metadata.py
Outdated
| ) | ||
| else: | ||
| if not allow_any_path: |
There was a problem hiding this comment.
This needs to be indented one level.
Happens to the best of us
jwodder
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think time to assume that all NWB files would have .nwb extension I think.
This PR is maintaining prior behavior of re-raising the exception if allow_any_path is
False. Otherwise -- and regardless if allow_any_path is True or not (thus
would not re-raise for non .nwb files even if not allow_any_path) - provide default
metadata record.
For upload it should be fine AFAIK even with the change of behavior since we first
use allow_any_path to select .nwb files.
Closes #730