Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: exit with non-0 when "bad_version" of dandi-cli is used #725

Merged
merged 2 commits into from
Jul 22, 2021

Conversation

yarikoptic
Copy link
Member

BadVersion was added in 0.2.2 thus boosting etelemetry version

BadVersion was added in 0.2.2 thus boosting etelemetry version
@codecov
Copy link

codecov bot commented Jul 22, 2021

Codecov Report

Merging #725 (9ac410b) into master (ee38041) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   84.06%   84.02%   -0.05%     
==========================================
  Files          59       59              
  Lines        5661     5664       +3     
==========================================
  Hits         4759     4759              
- Misses        902      905       +3     
Flag Coverage Δ
unittests 84.02% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/command.py 44.44% <0.00%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee38041...9ac410b. Read the comment docs.

dandi/cli/command.py Outdated Show resolved Hide resolved
@yarikoptic
Copy link
Member Author

2 approvals and linter still isn't happy, damn it! force pushed the fix

@yarikoptic
Copy link
Member Author

for one failed run filed #727 . I think we can proceed now

@yarikoptic yarikoptic merged commit cf0c118 into master Jul 22, 2021
@yarikoptic yarikoptic deleted the enh-et branch July 22, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants