Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install "test" extras when building docs #718

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Install "test" extras when building docs #718

merged 1 commit into from
Jul 21, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jul 21, 2021

The docs try to document a couple test modules that import pytest, so that needs to be installed when building the docs.

Closes #717.

@jwodder jwodder added internal Changes only affect the internal API documentation Changes only affect the documentation and removed internal Changes only affect the internal API labels Jul 21, 2021
@jwodder jwodder marked this pull request as ready for review July 21, 2021 14:27
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #718 (8d832f2) into master (7546b2d) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   83.96%   84.06%   +0.10%     
==========================================
  Files          59       59              
  Lines        5661     5661              
==========================================
+ Hits         4753     4759       +6     
+ Misses        908      902       -6     
Flag Coverage Δ
unittests 84.06% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/dandiapi.py 90.93% <0.00%> (+0.26%) ⬆️
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7546b2d...8d832f2. Read the comment docs.

@yarikoptic
Copy link
Member

woohoo -- RTD is happy, thank you @jwodder!

@yarikoptic yarikoptic merged commit ee38041 into master Jul 21, 2021
@yarikoptic yarikoptic deleted the gh-717 branch July 21, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Changes only affect the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix RTD build of sphinx docs in master
2 participants