Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_asset_metadata() function #693

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Add get_asset_metadata() function #693

merged 1 commit into from
Jul 6, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 30, 2021

Closes #692.

@jwodder jwodder added the minor Increment the minor version when merged label Jun 30, 2021
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #693 (0513032) into master (00357fa) will increase coverage by 0.21%.
The diff coverage is 90.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
+ Coverage   83.82%   84.03%   +0.21%     
==========================================
  Files          62       59       -3     
  Lines        6595     5624     -971     
==========================================
- Hits         5528     4726     -802     
+ Misses       1067      898     -169     
Flag Coverage Δ
unittests 84.03% <90.18%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/__init__.py 70.00% <ø> (ø)
dandi/cli/cmd_digest.py 100.00% <ø> (ø)
dandi/cli/tests/test_download.py 100.00% <ø> (+36.36%) ⬆️
dandi/exceptions.py 100.00% <ø> (ø)
dandi/support/generatorify.py 0.00% <0.00%> (-64.37%) ⬇️
dandi/tests/test_organize.py 93.60% <ø> (ø)
dandi/cli/cmd_shell_completion.py 32.00% <32.00%> (ø)
dandi/validate.py 52.94% <42.85%> (-0.23%) ⬇️
dandi/cli/cmd_organize.py 76.87% <50.00%> (-0.43%) ⬇️
dandi/cli/cmd_delete.py 81.81% <66.66%> (+1.81%) ⬆️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 404d0df...0513032. Read the comment docs.

@yarikoptic
Copy link
Member

Looks good to me and even green, so let's proceed. Thank you @jwodder !

@yarikoptic yarikoptic merged commit bccfed6 into master Jul 6, 2021
@yarikoptic yarikoptic deleted the gh-692 branch July 6, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

centralize logic for file2asset(path, ds)
2 participants