Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit repo versions and configure isort to properly handle "from . import" lines #656

Merged
merged 2 commits into from
Jun 7, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 7, 2021

No description provided.

@jwodder jwodder added the internal Changes only affect the internal API label Jun 7, 2021
@codecov
Copy link

codecov bot commented Jun 7, 2021

Codecov Report

Merging #656 (b4f6b43) into master (2489cf0) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   83.58%   83.63%   +0.05%     
==========================================
  Files          59       59              
  Lines        5348     5348              
==========================================
+ Hits         4470     4473       +3     
+ Misses        878      875       -3     
Flag Coverage Δ
unittests 83.63% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/cli/cmd_digest.py 100.00% <ø> (ø)
dandi/cli/cmd_ls.py 66.86% <ø> (ø)
dandi/exceptions.py 100.00% <ø> (ø)
dandi/cli/base.py 97.36% <100.00%> (ø)
dandi/cli/command.py 46.15% <100.00%> (ø)
dandi/dandiapi.py 92.33% <100.00%> (ø)
dandi/dandiarchive.py 84.57% <100.00%> (ø)
dandi/dandiset.py 84.21% <100.00%> (ø)
dandi/download.py 82.30% <100.00%> (+0.80%) ⬆️
dandi/metadata.py 67.98% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa9f7f...b4f6b43. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2021

This pull request introduces 1 alert and fixes 1 when merging 76f9dbc into 8aa9f7f - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2021

This pull request fixes 1 alert when merging b4f6b43 into 8aa9f7f - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@yarikoptic
Copy link
Member

Looks good to me. Even LGTM seems to be not non-useful ;-) Thanks @jwodder, let's proceed

@yarikoptic yarikoptic merged commit 0fa24ee into master Jun 7, 2021
@yarikoptic yarikoptic deleted the update-pre-commit branch June 7, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants