Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on ignored symlinks to directories #647

Merged
merged 1 commit into from
May 24, 2021
Merged

Warn on ignored symlinks to directories #647

merged 1 commit into from
May 24, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 24, 2021

Closes #641.

@jwodder jwodder added the patch Increment the patch version when merged label May 24, 2021
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #647 (6feb792) into master (edb49c6) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   83.32%   83.31%   -0.02%     
==========================================
  Files          58       58              
  Lines        5175     5177       +2     
==========================================
+ Hits         4312     4313       +1     
- Misses        863      864       +1     
Flag Coverage Δ
unittests 83.31% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/utils.py 80.39% <66.66%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edb49c6...6feb792. Read the comment docs.

@yarikoptic
Copy link
Member

I think this should suffice for now. thank you @jwodder !

@yarikoptic yarikoptic merged commit 0ac5c97 into master May 24, 2021
@yarikoptic yarikoptic deleted the gh-641 branch May 24, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upload using . to indicate present directory did not work
2 participants