Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut down on some code duplication in delete.py #610

Merged
merged 1 commit into from
May 3, 2021
Merged

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented May 3, 2021

Closes #606.

@jwodder jwodder added the internal Changes only affect the internal API label May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #610 (a58e164) into master (cf63ff9) will increase coverage by 0.16%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #610      +/-   ##
==========================================
+ Coverage   84.02%   84.18%   +0.16%     
==========================================
  Files          59       59              
  Lines        5728     5711      -17     
==========================================
- Hits         4813     4808       -5     
+ Misses        915      903      -12     
Flag Coverage Δ
unittests 84.18% <73.33%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/delete.py 92.56% <73.33%> (+6.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf63ff9...a58e164. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you! looks legit

@yarikoptic yarikoptic merged commit 31a2e50 into master May 3, 2021
@yarikoptic yarikoptic deleted the gh-606 branch May 3, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

delete: RF Deleter to avoid code duplication
2 participants