Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give "delete" a --skip-missing option #594

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Give "delete" a --skip-missing option #594

merged 1 commit into from
Apr 26, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Apr 23, 2021

Closes #592.

@jwodder jwodder added the minor Increment the minor version when merged label Apr 23, 2021
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #594 (4df5c02) into master (4e80384) will increase coverage by 0.03%.
The diff coverage is 77.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #594      +/-   ##
==========================================
+ Coverage   81.23%   81.26%   +0.03%     
==========================================
  Files          62       62              
  Lines        6601     6651      +50     
==========================================
+ Hits         5362     5405      +43     
- Misses       1239     1246       +7     
Flag Coverage Δ
unittests 81.26% <77.96%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/delete.py 89.10% <60.00%> (-7.14%) ⬇️
dandi/cli/cmd_delete.py 81.81% <66.66%> (+1.81%) ⬆️
dandi/tests/test_delete.py 100.00% <100.00%> (ø)
dandi/_version.py 45.96% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e80384...4df5c02. Read the comment docs.

@yarikoptic
Copy link
Member

Thank you @jwodder! Looks good and will test as deployed

@yarikoptic yarikoptic merged commit 6c61f1e into master Apr 26, 2021
@yarikoptic yarikoptic deleted the gh-592 branch April 26, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add --force to delete to skip for assets not found on the server
2 participants